Fix ALT overriding text input #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this approach not something you prefer I can edit it if you could share some quick feedback on this @ryanfleury. I can also close this if you would prefer to do it yourself. |
|
This issue was being caused by the debugger not properly interpreting AltGr-based input events correctly, and being too permissive in menu bar hotkey shortcuts, so the correct fix was a bit different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16
Set is_editing to true when an active panel begins an edit. If the panel focus goes somewhere else and the edit is still live in the background it should let you use ALT normally. This doesn't take commands into account so they need to be checked seperately.
One other check that I noticed was
ws->autocomp_last_frame_idx+1 >= df_frame_index()but this would only work for name types, like expressions where you have the auto complete available. The check in the commit should work for all input types that are build inDF_VIEW_UI_FUNCTION_DEF.